Revive AdServer Banner Rotation: US Date Format Showing As UK Date Format

[andrewatfornax]

Hey @420

In the GitHub ticket (linked above), you'll find a comment from me on 21 August, which links to the exact line of code where the date is being formatted for sending in emails.

Feel free to make the minor code change you need there to fix it yourself, if that's what you're looking to do!

[420]

1 hour ago, andrewatfornax said:

Hey @420

In the GitHub ticket (linked above), you'll find a comment from me on 21 August, which links to the exact line of code where the date is being formatted for sending in emails.

Feel free to make the minor code change you need there to fix it yourself, if that's what you're looking to do!

Do you know what we need to replace in the file by chance? (Off-topic note: The line is no longer accurate because of updates). 

Back around that time, we tried replacing

$oEndDate->format($date_format),

with 

$oEndDate->format('m-d-Y'),

But it didn't work. It displayed m-d-Y in the emails so we reverted the file back to its previous contents. 

 

[andrewatfornax]

https://pear.php.net/package/Date/docs/latest/Date/Date.html#methodformatLikeStrftime

I think you want a format string of:

%m-%d-%Y

[420]

On 12/17/2019 at 7:25 PM, andrewatfornax said:

https://pear.php.net/package/Date/docs/latest/Date/Date.html#methodformatLikeStrftime

I think you want a format string of:

%m-%d-%Y

We changed it to that and we're currently testing to see if it works. 

But I see a new version is out now. Was it fixed in the latest version? 

[andrewatfornax]

No changes related to this thread in 5.0.3:

https://github.com/revive-adserver/revive-adserver/blob/v5.0.3/RELEASE_NOTES.txt