Renaming asyncspc file doesn't work

[niska]

I've renamed asyncspc.php to anothername.php. I've also modified the conf-file to reflect the name change (asyncspc=anothername.php). However, when looking at the asyncjs.php in a browser it still contains the old filename. It doesn't use the filename in the conf-file. It seems as if "asyncspsc.php" is hardcoded.

Bug?

[niska]

It seems that async.js contains <?php echo MAX_commonConstructDeliveryUrl('asyncspc.php'); ?> - it's not using the value from the conf-file.

[andrewatfornax]

Thanks @niska,

If you have not already, can you please log as a bug on GitHub (and include a link back to this post in the report)?

[Matt Glover]

Team there is  bug in MAX_commonConstructDeliveryUrl - as you can see it hard codes the http prefix rather than using the request header value.

In my case, this was the cause of a CORS issue meaning we couldn't serve async ads from an insecure website. I hard coded mine to be https but in the bugfix it should be updated to use the X-Forwarded-Proto  et al request headers and return the appropriate field. We lost 3 man days over this one!!! but glad to have it sorted.

/**
 * A function to generate the URL for delivery scripts.
 *
 * @param string $file The file name of the delivery script.
 * @return string The URL to the delivery script.
 */
function MAX_commonConstructDeliveryUrl($file)
{
        $conf = $GLOBALS['_MAX']['CONF'];

        return 'http://' . $conf['webpath']['delivery'] . '/' . $file;

}
 

[Erik Geurts]

Issue create in Github: https://github.com/revive-adserver/revive-adserver/issues/710