Jump to content
Scott Switzer

Adding querystring variables from adjs/adframe to flow through to click and log URLs

Recommended Posts

Hi folks,

I am using Revive as part of an RTB bidding platform.  There are a ton of querystring variables that I want to pass through to the click and log URLs that are passed into the adjs call.  When I add a new variable, so the URL is something like:

http://localhost/revive/delivery/ajs.php?zoneid=1&cb=52153050782&foo=bar

The resulting javascript, which initiates the click and log URL's, does not contain foo=bar.

I set about creating a plugin to allow this.

+1 for an example plugin for every available hook!
+1 for additional documentation!
(I realize the irony here that the plugin framework was built while I was intimately involved with this project, and the documentation and examples should have come from my team :) )

After building a plugin based on the 'addUrlParams' hook, so the following componentParams get passed:  "foo" => "{foo}"

I realized that the values get URL encoded, so I cannot pass in a variable {foo} to be translated because it gets URL encoded.

Am I missing something here?  If not, can I submit a pull request where new values can be added in the config file?

Thanks!

Love, Scott

 

 

 

Share this post


Link to post
Share on other sites

Hey @Scott Switzer! Welcome to our forums, mate :)

I believe the feature is interesting, but I think a plugin might better serve the community, as the feature itself will probably be useful only to a small percentage of the user base. I think you are onto something with the plugin, and you might just need to swap {foo} for the actual $_REQUEST['foo'] value.

I'll have a look at the PR, but if we can get the plugin working, it would be even better IMHO.

 

 

Share this post


Link to post
Share on other sites

Yeah - plugin would be much better.  Why did I not think about just adding $_REQUEST['foo']?  

BTW - if you could point me to any plugin that has been built using the 'addUrlParams' hook, or any documentation on how to build a plugin at all, that would be fabulous!

Thanks

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...