Matt Peskett

I've just completed upgrades on two different revive ad server installations, on two different servers to 5.4.1 (both from v5.0.5), in each instance it seemed to run smoothly and admin looked OK at first but the ads had disappeared from all the sites and the zone area in Revive admin shows this above the list of zones per site. Any ideas? I tried updating PHP to 8 but no change. MAX_Dal_Delivery_Include(); function Plugin_deliveryLog_oxLogConversion_logConversion_Delivery_logConversion($trackerId, $serverRawIp, $aConversion, $okToLog = true) { if (!$okToLog) { return false; } OA_Dal_Delivery_connect('rawDatabase'); $table = $GLOBALS['_MAX']['CONF']['table']['prefix'] . 'data_bkt_a'; if (empty($GLOBALS['_MAX']['NOW'])) { $GLOBALS['_MAX']['NOW'] = time(); } $time = $GLOBALS['_MAX']['NOW']; $aValues = array( 'server_ip' => $serverRawIp, 'tracker_id' => (int)$trackerId, 'date_time' => gmdate('Y-m-d H:i:s', $time), 'action_date_time' => gmdate('Y-m-d H:i:s', $aConversion['dt']), 'creative_id' => (int)$aConversion['cid'], 'zone_id' => (int)$aConversion['zid'], 'ip_address' => $_SERVER['REMOTE_ADDR'], 'action' => $aConversion['action_type'], 'window' => $aConversion['window'], 'status' => $aConversion['status'] ); $aFields = array_map('OX_escapeIdentifier', array_keys($aValues)); $aValues = array_map('OX_escapeString', $aValues); $query = " INSERT INTO {$table} (" . implode(', ', $aFields) . ") VALUES ('" . implode("', '", $aValues) . "') "; $result = OA_Dal_Delivery_query($query, 'rawDatabase'); if (!$result) { return false; } $aResult = array( 'server_conv_id' => OA_Dal_Delivery_insertId('rawDatabase', $table, 'server_conv_id'), 'server_raw_ip' => $serverRawIp ); return $aResult; } ?> MAX_Dal_Delivery_Include(); function Plugin_deliveryLog_oxLogConversion_logConversionVariable_Delivery_logConversionVariable($aVariables, $trackerId, $serverConvId, $serverRawIp, $okToLog=true) { if (!$okToLog) { return false; } OA_Dal_Delivery_connect('rawDatabase'); $table = $GLOBALS['_MAX']['CONF']['table']['prefix'] . 'data_bkt_a_var'; if (empty($GLOBALS['_MAX']['NOW'])) { $GLOBALS['_MAX']['NOW'] = time(); } $time = $GLOBALS['_MAX']['NOW']; $aRows = array(); foreach ($aVariables as $aVariable) { $aRows[] = "( '".OX_escapeString($serverConvId)."', '".OX_escapeString($serverRawIp)."', '{$aVariable['variable_id']}', '".OX_escapeString($aVariable['value'])."', '".gmdate('Y-m-d H:i:s', $time)."' )"; } if (empty($aRows)) { return; } $query = " INSERT INTO {$table} ( server_conv_id, server_ip, tracker_variable_id, value, date_time ) VALUES " . implode(',', $aRows); return OA_Dal_Delivery_query($query, 'rawDatabase'); } ?> function Plugin_deliveryLog_OxLogImpression_LogImpression_Delivery_logImpression($adId = 0, $zoneId = 0, $okToLog = true) { if (!$okToLog) { return false; } $aData = $GLOBALS['_MAX']['deliveryData']; $aQuery = array( 'interval_start' => $aData['interval_start'], 'creative_id' => (int)$aData['creative_id'], 'zone_id' => (int)$aData['zone_id'] ); return OX_bucket_updateTable('data_bkt_m', $aQuery); } function Plugin_deliveryLog_oxLogRequest_logRequest_Delivery_logRequest($adId = 0, $zoneId = 0, $aAd = array(), $okToLog = true) { if (!$okToLog) { return false; } $aData = $GLOBALS['_MAX']['deliveryData']; $aQuery = array( 'interval_start' => $aData['interval_start'], 'creative_id' => (int)$aData['creative_id'], 'zone_id' => (int)$aData['zone_id'] ); return OX_bucket_updateTable('data_bkt_r', $aQuery); } ?> Logfiles on server show AH01071: Got error 'PHP message: PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function MAX_ErrorHandler::errHandler(), 4 passed in /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/max/other/lib-acl.inc.php on line 15 and exactly 5 expected in /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/max/ErrorHandler.php:95\nStack trace:\n#0 /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/max/other/lib-acl.inc.php(15): MAX_ErrorHandler->errHandler()\n#1 /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/max/other/lib-acl.inc.php(15): require_once()\n#2 /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/max/other/common.php(14): require_once('...')\n#3 /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/OA/Permission.php(17): require_once('...')\n#4 /var/www/vhosts/akabomedia.co.uk/webdisplay.akabomedia.co.uk/server/lib/OA/Dll.php(18): require_once('...')\n#5 /var/www/vhosts/akabomedia.co.u...', referer: https://webdisplay.akabomedia.co.uk/server/www/admin/affiliate-zones.php Thanks Matt

Been using Revive (OpenX) for 15 years, had it installed on at least five different servers in that time and never had any performance issues, until now. It's hosted alongside three Wordpress magazine sites on a box, not particularly high traffic sites (maybe peaks of 30 people a minute across all three sites) but they keep timing out, 502s etc. The problem stops and they return to their normal lightning speed delivery when I deactivate the Revive domain (and all their banner ads). Only started 4 weeks ago, not sure why - has anybody come across similar issues? What sort of things can be done to optimise performance and reduce PHP overheads, it's not a memory issue (2GB used of 16Gb available). Cheers

Also for issues like this when you know your www/images folder permissions are good, don't forget to check the full Local Directory path here: Configuration > Global Settings > Banner Storage Settings Tick 'Allow Webserver Local Banners' Check 'Local Directory' path. One way to find out if this path is correct is to go to this section in admin and click the save button at the bottom of the page without changing anything. If there's an error it will show up immediately.