Jump to content

jamieburchell

Approved members
  • Content Count

    14
  • Joined

  • Last visited

Reputation Activity

  1. Upvote
    jamieburchell got a reaction from w-sky in Wrong from address in automatic email   
    Please can I request that the Revive team take another look at this, as it's still an issue today.
    I already took the step to force an envelope sender address:
    php_value[sendmail_path] = /usr/sbin/sendmail -t -i -fnobody@example.com
    But if you see, it's the other from address that is getting set/mangled by Revive:
    To: "Administrator" <team@xxx>
    Subject: Impending campaign expiration: XXX
    X-PHP-Originating-Script: 1005:Email.php
    ...
    From: "n" <n@mymailserver.domain>
    X-Original-Authentication-Results: mx.google.com;       dkim=pass
     header.i=@example.com header.s=krs header.b="b/nn6hqL";       spf=pass
     (google.com: domain of nobody@example.com designates XXX as
     permitted sender) smtp.mailfrom=nobody@example.com
     
    Line in maillog:
    Sep 12 00:05:03 x postfix/cleanup[1549]: 9F27F4696CC: prepend: header From: "n" <n> from local; from=<nobody@example.com>: X-Mailgun-Native-Send: true
    In my Revive config:
    [ email ] (without spaces)
    logOutgoing=1
    headers=
    qmailPatch=
    fromName="Admin"
    fromAddress="no-reply@example.com"
    fromCompany="My Company"
    useManagerDetails=
    Further, all of my Advertisers have email addresses and names configured.
    I think there's at least one potential issue in the Email.php file:
    https://github.com/revive-adserver/revive-adserver/blob/master/lib/OA/Email.php#L53
    What happens if $aConf['email']['useManagerDetails'] is false? $aFromDetails does not get defined but is used further down.
    TIA
    Jamie
     
  2. Upvote
    jamieburchell got a reaction from andrewatfornax in please fix all errors   
    Turns out that's fixed by setting the correct images path in the config *doh*
×
×
  • Create New...